[DC-AE, SANA] fix SanaMultiscaleLinearAttention apply_quadratic_attention bf16 #10595
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @chenjy2003! Is this a fix for #10590? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Yes. This one is for that issue. |
a-r-r-o-w
approved these changes
Jan 16, 2025
|
Verified the following issue using this PR, confirmed working and Tested Sana 4K model (enable_tiling) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue in
SanaMultiscaleLinearAttentionapply_quadratic_attention. In bf16 setting, the data type ofvalueandscoreswill not match and cause an error.Could you please have a look? Thanks! @sayakpaul @yiyixuxu @a-r-r-o-w
Cc: @lawrence-cj